-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: manipulate entire context instead of TestSetXXX #3582
base: master
Are you sure you want to change the base?
refactor: manipulate entire context instead of TestSetXXX #3582
Conversation
🛠 PR Checks Summary🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
…nd + remove X_testSetOrigSend
…remove X_testSetOrigPkgAddr
If possible, lets rename and modify Once we get the API down, let me know, and I'll help on modifying the docs for this. |
IMHO, SkipHeigh make more sense with current usage and simpler to use because we do not need to get the current height to calculate the "newHeight" to set with SetHeight. I think we could have SetHeight and SetTimestamp if needed but usages are not the same. WDYT ? @leohhhn |
Linked to #1475